You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While I don't have a problem with the implementation (a bit hacky though), this situation makes me feel like it's a dilemma.
SQLAlchemy is very popular that there are many tools built based on it, including db migration, web framework integration and profiler in this case.
On one hand, I think we definitely should support those features, or at least expose interfaces for other packages to implement; on the other hand, those existing tools may already have many users who have got used to them, and it might be hard, even conflicting, to support all the synchronous libraries, as it's not the same way to think in sync and async.
But, well, let's admit, inventing new tools takes a lot of time and effort, which can be hard for a full-time job, let alone for part-time maintainers.
I want to say no, but I can't give a solution to that, so I'll hope someday we can have a better, more async friendly solution.
(Sorry, I haven't checked what SQLTap does and how much effort to rebuild an async version.)
Revisited this PR.
I think rowcount will be useful in some cases.
I'm not sure about the event part, as we already have #161 and #435. Do you want to have a more complete implementation instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #412
before_cursor_execute()andafter_cursor_execute()is untouched - maybe we can create new events forasync_execute()if needed by someone.rowcountplease? It's not a public API so it should be fine in most cases.